Fix AC order for FLAVA example #434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ShardedGradScaler not needed for bf16 training. Differential Revision: D47218367 fbshipit-source-id: 143269cc8dc05805b3caebe73035ce0f39c7e8d4
Summary: There have been some fixes to the non-reentrant AC and FLAVA model now works with it. Differential Revision: D47218368 fbshipit-source-id: 448969eb42e6df224dcd7ea82b4fabe63dcecf96
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47218368 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
==========================================
+ Coverage 68.61% 68.63% +0.01%
==========================================
Files 169 169
Lines 11338 11336 -2
==========================================
Hits 7780 7780
+ Misses 3558 3556 -2
☔ View full report in Codecov by Sentry. |
ankitade
reviewed
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There have been some fixes to the non-reentrant AC and FLAVA model now works with it.
Differential Revision: D47218368