Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CA to albef dir #437

Closed
wants to merge 1 commit into from
Closed

Move CA to albef dir #437

wants to merge 1 commit into from

Conversation

ankitade
Copy link
Contributor

@ankitade ankitade commented Jul 21, 2023

Summary:
Moving cross attn to albef since its only used by albef

Test plan:
pytest tests/models/albef/test_albef.py

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (1940623) 68.65% compared to head (f36b1d4) 68.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   68.65%   68.66%   +0.01%     
==========================================
  Files         169      169              
  Lines       11350    11355       +5     
==========================================
+ Hits         7792     7797       +5     
  Misses       3558     3558              
Impacted Files Coverage Δ
tests/modules/layers/test_transformer.py 100.00% <ø> (ø)
torchmultimodal/modules/layers/transformer.py 98.66% <ø> (-0.56%) ⬇️
tests/models/albef/test_albef.py 100.00% <100.00%> (ø)
torchmultimodal/models/albef/multimodal_encoder.py 98.57% <100.00%> (+5.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ankitade ankitade requested a review from ebsmothers July 21, 2023 01:07
@ankitade ankitade marked this pull request as ready for review July 21, 2023 01:07
@facebook-github-bot
Copy link
Contributor

@ankitade has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ankitade merged this pull request in 82c1dc2.

@ankitade ankitade deleted the albef_ca branch July 24, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants