Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move transformer impl to flava folder #439

Closed
wants to merge 3 commits into from
Closed

Move transformer impl to flava folder #439

wants to merge 3 commits into from

Conversation

ankitade
Copy link
Contributor

@ankitade ankitade commented Jul 27, 2023

Summary:
Only used by flava so moving it to that folder to make space for the other transformer. will rename to flava transformer in a followup

Test plan:
pytest tests/
sanity check
torchrun --nproc_per_node=1 -m flava.native.train config=flava/native/configs/pretrain_debug.yaml

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 27, 2023
@facebook-github-bot
Copy link
Contributor

@ankitade has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Patch coverage: 97.61% and no project coverage change.

Comparison is base (97264a2) 68.72% compared to head (9b2f295) 68.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   68.72%   68.72%           
=======================================
  Files         169      169           
  Lines       11376    11374    -2     
=======================================
- Hits         7818     7817    -1     
+ Misses       3558     3557    -1     
Files Changed Coverage Δ
examples/flava/native/train.py 0.00% <0.00%> (ø)
torchmultimodal/models/flava/transformer.py 97.22% <98.52%> (+2.10%) ⬆️
tests/models/flava/test_image_encoder.py 100.00% <100.00%> (ø)
tests/models/flava/test_text_encoder.py 100.00% <100.00%> (ø)
tests/models/flava/test_transformer.py 100.00% <100.00%> (ø)
torchmultimodal/models/flava/image_encoder.py 75.00% <100.00%> (ø)
torchmultimodal/models/flava/model.py 95.57% <100.00%> (ø)
torchmultimodal/models/flava/text_encoder.py 100.00% <100.00%> (ø)
...chmultimodal/modules/encoders/bert_text_encoder.py 90.47% <100.00%> (+0.23%) ⬆️
torchmultimodal/modules/layers/transformer.py 100.00% <100.00%> (+1.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

@ankitade has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ankitade merged this pull request in 1aa2ed2.

@ankitade ankitade deleted the transformer_1 branch August 20, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants