Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attn_mask shape in MHA docstrings #441

Closed

Conversation

ebsmothers
Copy link
Contributor

Summary: n/a

Reviewed By: ankitade, pikapecan

Differential Revision: D47998161

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Aug 2, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47998161

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (1aa2ed2) 68.72% compared to head (4e719a4) 68.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
- Coverage   68.72%   68.70%   -0.03%     
==========================================
  Files         169      169              
  Lines       11374    11374              
==========================================
- Hits         7817     7814       -3     
- Misses       3557     3560       +3     
Files Changed Coverage Δ
...hmultimodal/modules/layers/multi_head_attention.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ebsmothers added a commit to ebsmothers/multimodal that referenced this pull request Aug 2, 2023
Summary:
Pull Request resolved: facebookresearch#441

n/a

Reviewed By: ankitade, pikapecan

Differential Revision: D47998161

fbshipit-source-id: b65e1dd81b13a83641a2ffc5492dea2ee5ed08fe
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47998161

Summary:
Pull Request resolved: facebookresearch#441

n/a

Reviewed By: ankitade, pikapecan

Differential Revision: D47998161

fbshipit-source-id: 070fb03c81a1fed8d299e9a0d09463fe528b488f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47998161

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 81e281c.

@ebsmothers ebsmothers deleted the export-D47998161 branch August 2, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants