Add RMSNorm (part of parallel_attn_blocks) #448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds RMSNorm.
It is used in parallel_attention_blocks but moving the earlier mono PR for that into smaller chunks for easier review and landing.
Test plan:
added two units tests:
test_rms_norm_fp32
test_rms_core_algo (compares F.norm version vs PR version)
Fixes:
Adds requested doc string to RMSNorm from earlier PR review.