Consolidate VideoGPT components #478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49753884 |
|
This pull request was exported from Phabricator. Differential Revision: D49753884 |
Summary: Condolidating all of the VideoGPT components and models into a single folder which follows our general convention. This change also removes model-specific components like AxialAttention from the general library to reduce confusion for users. Full set of changes include: - Move gpt.y, video_gpt.py and video_vqvae.py to models/video_gpt/ - Rename video_gpt.py to model.py to follow convention - Move AxialAttention and AxialAttentionBlock to video_vqvae.py - Update all tests - Update code in examples/mugen Reviewed By: ebsmothers, pikapecan Differential Revision: D49753884
kartikayk
force-pushed
the
export-D49753884
branch
from
d1d2539
to
037027b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49753884 |
|
This pull request has been merged in 0de91e1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Condolidating all of the VideoGPT components and models into a single folder which follows our general convention. This change also removes model-specific components like AxialAttention from the general library to reduce confusion for users.
Full set of changes include:
Reviewed By: ebsmothers, pikapecan
Differential Revision: D49753884