Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring of CLIP model #523

Closed
wants to merge 1 commit into from

Conversation

willyfh
Copy link
Contributor

@willyfh willyfh commented Feb 17, 2024

Summary:

Fix typo and missing description for layers

Test plan:

Fixes #{issue number}

Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
@willyfh willyfh closed this Feb 17, 2024
@willyfh willyfh reopened this Feb 17, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 17, 2024
@facebook-github-bot
Copy link
Contributor

@ebsmothers has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2cbab1f) 75.61% compared to head (561f714) 75.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #523   +/-   ##
=======================================
  Coverage   75.61%   75.61%           
=======================================
  Files         234      234           
  Lines       16122    16122           
=======================================
  Hits        12191    12191           
  Misses       3931     3931           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ebsmothers ebsmothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willyfh for the PR! Looks good to me

@facebook-github-bot
Copy link
Contributor

@ebsmothers merged this pull request in 5a6a283.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants