Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mypy version #524

Closed
wants to merge 1 commit into from

Conversation

ebsmothers
Copy link
Contributor

@ebsmothers ebsmothers commented Feb 22, 2024

Summary:
Our CI is failing (ex) due to a mismatch in the mypy version used with pytorch core. Update mypy version to fix it

Test plan:
Fresh install and run mypy

conda install pytorch torchvision torchaudio pytorch-cuda=12.1 -c pytorch-nightly -c nvidia
pip install -e ".[dev]"
mypy
Success: no issues found in 135 source files

CI is green now

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 22, 2024
@facebook-github-bot
Copy link
Contributor

@ebsmothers has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2cbab1f) 75.61% compared to head (c13f3c0) 75.61%.

Files Patch % Lines
torchmultimodal/utils/common.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #524   +/-   ##
=======================================
  Coverage   75.61%   75.61%           
=======================================
  Files         234      234           
  Lines       16122    16122           
=======================================
  Hits        12191    12191           
  Misses       3931     3931           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

@ebsmothers merged this pull request in c261d71.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants