set bias=True for linear layer (#526) #527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55897450 |
zhangtemplar
added a commit
to zhangtemplar/multimodal
that referenced
this pull request
Apr 9, 2024
Summary: 1. for output projection in text decoder, change bias=False to True. In many other places, e.g., LP head, ember's output module and LLAVA, they are using bias=True (which is default value in Linear). 2. add configuration of using MLP instead of attention pooler for vision adapter; Differential Revision: D55897450 Privacy Context Container: 303860477774201
zhangtemplar
force-pushed
the
export-D55897450
branch
from
802b0c3
to
e0e2ee7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55897450 |
Summary: 1. for output projection in text decoder, change bias=False to True. In many other places, e.g., LP head, ember's output module and LLAVA, they are using bias=True (which is default value in Linear). 2. add configuration of using MLP instead of attention pooler for vision adapter; Differential Revision: D55897450 Privacy Context Container: 303860477774201
zhangtemplar
force-pushed
the
export-D55897450
branch
from
e0e2ee7
to
92bd094
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55897450 |
|
This pull request has been merged in e4d288b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision:
D55897450
Privacy Context Container: 303860477774201