add possibly missing unlock, related to #17

facil-io · Sep 30, 2023 · a82f489 · a82f489
1 parent b65e606
commit a82f489
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/fio-stl.h b/fio-stl.h
@@ -15949,8 +15949,10 @@ SFUNC int fio_queue_workers_add(fio_queue_s *q, size_t workers) {
     q->consumers = FIO_LIST_INIT(q->consumers);
   }
   fio___thread_group_s grp = {.queue = q, .workers = workers, .stop = 1};
-  if (fio_thread_create(&grp.thread, fio___queue_worker_manager, &grp))
+  if (fio_thread_create(&grp.thread, fio___queue_worker_manager, &grp)) {
+    FIO___LOCK_UNLOCK(q->lock);
     return -1;
+  }
   while (grp.stop)
     FIO_THREAD_RESCHEDULE();
   FIO___LOCK_UNLOCK(q->lock);

diff --git a/fio-stl/102 queue.h b/fio-stl/102 queue.h
@@ -567,8 +567,10 @@ SFUNC int fio_queue_workers_add(fio_queue_s *q, size_t workers) {
     q->consumers = FIO_LIST_INIT(q->consumers);
   }
   fio___thread_group_s grp = {.queue = q, .workers = workers, .stop = 1};
-  if (fio_thread_create(&grp.thread, fio___queue_worker_manager, &grp))
+  if (fio_thread_create(&grp.thread, fio___queue_worker_manager, &grp)) {
+    FIO___LOCK_UNLOCK(q->lock);
     return -1;
+  }
   while (grp.stop)
     FIO_THREAD_RESCHEDULE();
   FIO___LOCK_UNLOCK(q->lock);