+ correctly expose methods option to recover compatibility to vue-class-component
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tall1on
changed the title
methods option to recover compatibility to vue-class-component
|
Really needed thanks for the PR! |
ruojianll
reviewed
Sep 20, 2023
ruojianll
reviewed
Sep 20, 2023
ruojianll
reviewed
Sep 20, 2023
ruojianll
reviewed
Sep 20, 2023
ruojianll
requested changes
Sep 20, 2023
|
I guess i overthought it a bit 😅 I changed everything you asked, all tests passed. |
ruojianll
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I noticed that the
methodsoption doesn't work like the one fromvue-class-component, so I added it. I also improved a bit of other code. Tests have all been passed. I also edited themethodstest to make sure it keeps working like invue-class-component.