Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow_run #307

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Fix workflow_run #307

merged 2 commits into from
Nov 22, 2022

Conversation

florimondmanca
Copy link
Contributor

@florimondmanca florimondmanca commented Nov 18, 2022

Correctif de #305... En fait si on garde push, alors le workflow deploy.yml se lance 2 fois : une fois lors du push, une deuxième fois quand ci.yml a terminé... Il faut donc garder seulement workflow_run.

Je passe aussi un fix suite à #306... Il semble que supervisorctl ne soit pas très "isomorphe" : la tâche échoue si le process visé n'existe pas, au lieu de ne rien faire... Comme ça a été déployé, effectivement le process client n'existe plus donc je retire la tâche.

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 90.96% // Head: 90.96% // No change to project coverage 👍

Coverage data is based on head (e6f9cd2) compared to base (074a9bf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         261      261           
  Lines        3122     3122           
  Branches      174      174           
=======================================
  Hits         2840     2840           
  Misses        281      281           
  Partials        1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@florimondmanca florimondmanca merged commit a465a23 into master Nov 22, 2022
@florimondmanca florimondmanca deleted the fm/fix-deploy-workflow_fun branch November 22, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants