Skip to content

Commit

Permalink
docs: clean up more newsfragments from the breakingchange section
Browse files Browse the repository at this point in the history
  • Loading branch information
vytas7 committed Oct 6, 2024
1 parent 9bae121 commit 692de31
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 10 deletions.
7 changes: 3 additions & 4 deletions docs/_newsfragments/2090.breakingchange.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
The deprecated ``api_helpers`` was removed in favor of the ``app_helpers``
module. In addition, the deprecated ``body``
attributes for the :class:`~falcon.Response`,
:class:`asgi.Response <falcon.asgi.Response>`,
and :class:`~falcon.HTTPStatus` classes.
module. In addition, the deprecated ``body`` attributes of the
:class:`~falcon.Response`, :class:`asgi.Response <falcon.asgi.Response>`, and
:class:`~falcon.HTTPStatus` classes were removed.
13 changes: 8 additions & 5 deletions docs/_newsfragments/2343.breakingchange.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
Removed ``is_async`` argument from :meth:`~falcon.media.validators.jsonschema.validate`
and the hooks :meth:`~falcon.before` and :meth:`~falcon.after` since it's
no longer needed.
Cython from 3.0 will correctly mark ``asnyc def`` as coroutine, making
this argument no longer useful.
The ``is_async`` keyword argument was removed from
:meth:`~falcon.media.validators.jsonschema.validate`, as well as the hooks
:meth:`~falcon.before` and :meth:`~falcon.after`, since it represented a niche
use case that is even less relevant with the recent advances in the ecosystem:
Cython 3.0+ will now correctly mark cythonized ``async def`` functions as
coroutines, and pure-Python factory functions that return a coroutine can now
be marked as such using :func:`inspect.markcoroutinefunction`
(Python 3.12+ is required).
2 changes: 1 addition & 1 deletion falcon/response.py
Original file line number Diff line number Diff line change
Expand Up @@ -1371,7 +1371,7 @@ class ResponseOptions:

secure_cookies_by_default: bool
"""Set to ``False`` in development environments to make the ``secure`` attribute
for all cookies. (default ``False``).
for all cookies. (default ``True``).
This can make testing easier by not requiring HTTPS. Note, however, that this
setting can be overridden via :meth:`~.Response.set_cookie()`'s ``secure`` kwarg.
Expand Down

0 comments on commit 692de31

Please sign in to comment.