Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multipart): do not require CRLF after the closing delimiter #2366

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix(multipart): do not require CRLF after the closing delimiter #2366

merged 2 commits into from
Oct 10, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Oct 10, 2024

Fixes #2364.

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (06fdf28) to head (b8c3beb).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #2366   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         7727      7725    -2     
  Branches      1073      1071    -2     
=========================================
- Hits          7727      7725    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CaselIT
CaselIT approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to have it for 4.0 since it could break people tests

@vytas7 vytas7 merged commit db33c9c into falconry:master Oct 10, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaselIT CaselIT CaselIT approved these changes

@kgriffs kgriffs Awaiting requested review from kgriffs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multipart form parser should not require CRLF after the closing --
2 participants
@vytas7 @CaselIT