Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(testing): deprecate testtools support in TestCase #2405

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 48 additions & 17 deletions falcon/testing/test_case.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,25 @@
utilities for simulating and validating HTTP requests.
"""

try:
import testtools as unittest
except ImportError: # pragma: nocover
import unittest
import os
import unittest
import warnings

if 'DISABLE_TESTTOOLS' not in os.environ:
try:
import testtools

warnings.warn(

Check warning on line 29 in falcon/testing/test_case.py

View check run for this annotation

Codecov / codecov/patch

falcon/testing/test_case.py#L29

Added line #L29 was not covered by tests
'Support for testtools is deprecated and will be removed in Falcon 5.0. '
'Please migrate to unittest or pytest.',
DeprecationWarning,
)
BaseTestCase = testtools.TestCase

Check warning on line 34 in falcon/testing/test_case.py

View check run for this annotation

Codecov / codecov/patch

falcon/testing/test_case.py#L34

Added line #L34 was not covered by tests
except ImportError: # pragma: nocover
BaseTestCase = unittest.TestCase

import falcon
import falcon.request

# TODO hoist for backwards compat. Remove in falcon 4.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove this note!
We missed it in Falcon 4.0 it seems, so it needs to be updated to say Falcon 5.0, if you want to touch it.

from falcon.testing.client import Result # NOQA
from falcon.testing.client import TestClient

Expand All @@ -35,16 +45,45 @@
"""Extends :mod:`unittest` to support WSGI/ASGI functional testing.

Note:
If available, uses :mod:`testtools` in lieu of
:mod:`unittest`.
This class uses :mod:`unittest` by default. If :mod:`testtools`
is available and the environment variable
``DISABLE_TESTTOOLS`` is **not** set, it will use :mod:`testtools` instead.
**Support for testtools is deprecated and will be removed in Falcon 5.0.**

Recommended:
We recommend using **pytest** for testing Falcon applications.
See our tutorial on using pytest.

This base class provides some extra plumbing for unittest-style
test cases, to help simulate WSGI or ASGI requests without having
to spin up an actual web server. Various simulation methods are
derived from :class:`falcon.testing.TestClient`.

Simply inherit from this class in your test case classes instead of
:class:`unittest.TestCase` or :class:`testtools.TestCase`.
:class:`unittest.TestCase`.

For example::

from falcon import testing
import myapp


class MyTestCase(testing.TestCase):
def setUp(self):
super(MyTestCase, self).setUp()

# Assume the hypothetical `myapp` package has a
# function called `create()` to initialize and
# return a `falcon.App` instance.
self.app = myapp.create()


class TestMyApp(MyTestCase):
def test_get_message(self):
doc = {'message': 'Hello world!'}

result = self.simulate_get('/messages/42')
self.assertEqual(result.json, doc)
"""

# NOTE(vytas): Here we have to restore __test__ to allow collecting tests!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you removed my note?

Expand All @@ -69,14 +108,6 @@
# function called `create()` to initialize and
# return a `falcon.App` instance.
self.app = myapp.create()


class TestMyApp(MyTestCase):
def test_get_message(self):
doc = {'message': 'Hello world!'}

result = self.simulate_get('/messages/42')
self.assertEqual(result.json, doc)
"""

def setUp(self) -> None:
Expand Down
Loading