Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: implement list function #10

Merged
merged 17 commits into from
Jan 26, 2024
Merged

Conversation

fersaru
Copy link
Collaborator

@fersaru fersaru commented Jan 21, 2024

Implements a list command with note.js as the template.

Things that still needs to be addressed are:

  • some sort of interface for reporting errors to the frontend
  • finding a fitting place for error logs without disturbing the user but having a opportunity to get more information about an error
  • tests in rust for the backend only

src-tauri/src/main.rs Outdated Show resolved Hide resolved
@falk-werner
Copy link
Owner

In order to test this, we might want to provide a test directory. Than we can prepare a test directory of some structure and how our implementation react. We also might want to configure the directory later. In note.py and note.js, yaml configuration files are used. We don't need to introduce yaml configuration here (but we can, if you want to), but we should at least provide some directory to the implementation for test automation.

@fersaru
Copy link
Collaborator Author

fersaru commented Jan 21, 2024

In order to test this, we might want to provide a test directory. Than we can prepare a test directory of some structure and how our implementation react. [..] but we should at least provide some directory to the implementation for test automation.

I was thinking: maybe actual files are not needed. I want to check how deep I can mock things. But if I can't mock as early as I want, I think for test purposes, generating a test directory with content and deleting it after a test would be the best.

We also might want to configure the directory later. In note.py and note.js, yaml configuration files are used. We don't need to introduce yaml configuration here (but we can, if you want to),

A configuration for the storage location must be possible. Currently there is no menu to do so. A file for storing this information permanently is vital. Yaml, Json or toml syntax shouldn't be a problem since rust has crates for everything.

@falk-werner
Copy link
Owner

falk-werner commented Jan 21, 2024

Currently there is no menu to do so

In note.py and note we only had config files without any in-app configuration. Here, we already have a settings menu. Take a look at the extra buttons on our title bar. There is only one option there by now and I don't know if it's worth to keep this particular option, but we can add more options there.

@fersaru fersaru force-pushed the feature/backend/list-command branch from f5efa8e to 3039294 Compare January 26, 2024 08:49
@fersaru fersaru force-pushed the feature/backend/list-command branch from 3039294 to aafa21a Compare January 26, 2024 08:50
src-tauri/src/main.rs Outdated Show resolved Hide resolved
src-tauri/src/main.rs Outdated Show resolved Hide resolved
src-tauri/src/main.rs Outdated Show resolved Hide resolved
src-tauri/src/main.rs Outdated Show resolved Hide resolved
src-tauri/src/main.rs Outdated Show resolved Hide resolved
src-tauri/src/main.rs Outdated Show resolved Hide resolved
@falk-werner falk-werner self-requested a review January 26, 2024 19:59
@fersaru fersaru marked this pull request as ready for review January 26, 2024 20:29
@falk-werner falk-werner merged commit b2cc3e4 into main Jan 26, 2024
3 checks passed
@falk-werner falk-werner deleted the feature/backend/list-command branch January 26, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants