Fixing the torch and sbi version to the last actively tested ones #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the thing is that the two flavors with build the
libtorch.so
could be removed if we would update to the latest torch v1.XAs nice as it sounds, this requires a lot of effort, i.e.:
USE_LIBTORCH
inrcspysim
(CMakeLists and the root setup.py)to.lstsq(self.conds[:, idx_act], feats).solution
withto.linalg.lstsq(feats, self.conds[:, idx_act]).solution
in `ploy_time.pyIn fact, I think we could even just install torch and all the torch-dependent libs in
setup_deps.py
simply with pip and make everything way cleaner. Unfortunately, I do not have the time for that and rather archive this project at the last state where I know it worked. Therefore, I undid the recent change that removed the--no-deps
when installing gpytorch and botorch.