Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the torch and sbi version to the last actively tested ones #102

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

famura
Copy link
Owner

@famura famura commented Dec 19, 2023

So the thing is that the two flavors with build the libtorch.so could be removed if we would update to the latest torch v1.X

As nice as it sounds, this requires a lot of effort, i.e.:

  1. Removing the entire block with USE_LIBTORCH in rcspysim (CMakeLists and the root setup.py)
  2. Replacing to.lstsq(self.conds[:, idx_act], feats).solution with to.linalg.lstsq(feats, self.conds[:, idx_act]).solution in `ploy_time.py

In fact, I think we could even just install torch and all the torch-dependent libs in setup_deps.py simply with pip and make everything way cleaner. Unfortunately, I do not have the time for that and rather archive this project at the last state where I know it worked. Therefore, I undid the recent change that removed the --no-deps when installing gpytorch and botorch.

@famura famura added the bug fix Something isn't working label Dec 19, 2023
@famura famura requested a review from fdamken December 19, 2023 17:16
@famura famura self-assigned this Dec 19, 2023
@famura famura requested a review from miterion December 19, 2023 17:20
Copy link
Collaborator

@miterion miterion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3e88a5) 61.48% compared to head (c1e8df6) 61.48%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   61.48%   61.48%           
=======================================
  Files         199      199           
  Lines       20176    20176           
=======================================
  Hits        12405    12405           
  Misses       7771     7771           
Flag Coverage Δ
unittests 61.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@famura famura changed the title Fixing the torch and sbi version to the last ones actively tested Fixing the torch and sbi version to the last actively tested ones Dec 20, 2023
@famura famura merged commit 36bc884 into master Dec 20, 2023
8 checks passed
@famura famura deleted the fix/installation branch December 20, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants