Release v2.6.1 of Django-Jazzmin #540
Conversation
Adds support for Django 4.2 Changes: - Remove errant “sourceMappingURL” referencing a non-existent file (@codyfletcher) (farridav#474)
|
Hi @jamesgilmorelyst thanks for your PR, as you can tell, I've not had much time to work on jazzmin recently, and every time I do get a little bit (like now), I see that we have so many pull requests (which is good), and also a lot of issues (most of which were asking about providing integration support for other django packages that toy with the admin) As a result of this, I'm often overwhelmed with the backlog of work (and also that of other commitments), and do nothing instead (which is understandably not ideal) and i think @TysonRV is also not in a position to help maintain. Putting a new release out is easy enough, especially if there are unreleased changes in |
|
Thanks, @farridav. Yeah, I can imagine how overwhelming this project might be after seeing how many issues/PRs there are. I am happy to help triage issues so that regular updates on this project can resume. Let me know where I can help with this project. |
Known issue of the `action/setup-python` action [0]. Workaround is to pin the ubuntu image to a known working version [1]. This is consistent with pinning most other packages anyway so don't think this is much of an issue. [0] actions/setup-python#544 [1] actions/setup-python#544 (comment)
|
@farridav Also, there was an issue with the build process, which seems to be related to the Ubuntu image being used no longer supporting 3.6 of PY. To maintain support for now, it was recommended to pin the image to a known working version. Did you mind re-approving, please? (sorry for the hassle) https://github.com/farridav/django-jazzmin/actions/runs/8374469998 |
|
@farridav sorry for the back and forth, but the GHA failed again - https://github.com/farridav/django-jazzmin/actions/runs/8376078256/job/22936795892 I'm not really sure why this is needed, and running locally with/without this package on tox doesn't seem to be required. So, I've removed it. The commit this was added doesn't seem to add any context to why this was needed. I've also fixed a bug in the test for v4.8 of Django, which added a new Tox passes locally for me now. Do you mind approving again, please, to check GHA is also happy, please? |
|
No worries, I appreciate you taking the time to help out, and will find a way to onboard you to the maintainers if you have spare time going forwards . |
In Django 4.8 there is a change to the tests need as the date widget was added - `admin/widgets/date.html`.
Warning message from GHA before version bump: ``` Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. ```
jamesgilmorelyst
force-pushed
the
release-v2.6.1
branch
from
bf9c561 to
698aa6d
Compare
|
Thanks, @farridav. I'm happy to help, and it will be great to be able to help maintain this package. I probably should have done this earlier, but I've managed to get the GHA issues sorted now by running this on my forked repo: So, hopefully, this time, GHA will pass! Also happy just to open a new PR with these build fixes to separate it from the actual release. |
Only impacts certain version of Python, where the `flake8` package is trying to get the entrypoints of a package using a deprecated method of importlib-metadata. Basically just an issue with the package dependencies not being defined very well downstream.
jamesgilmorelyst
force-pushed
the
release-v2.6.1
branch
from
698aa6d to
a56b972
Compare
Adds support for Django 4.2
Changes: