Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve static code checks #548

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Improve static code checks #548

wants to merge 5 commits into from

Conversation

farridav
Copy link
Owner

  • Adds type checks with mypy
  • Adds types
  • Fixes flake8 issues

@farridav farridav force-pushed the tech/improve_static_code_checks branch from 5bbda77 to f2fc363 Compare March 25, 2024 09:12
@jamesgilmorelyst
Copy link

Nice change. Great to have mypy in this repo!

Curious - should we look at adding ruff as well to this repo so we can remove, black, flake8 and isort? Happy to raise a PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farridav @jamesgilmorelyst @katiam2