Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: set MSRV to 1.75 and update fastrace #53

Merged
merged 2 commits into from
Aug 14, 2024
Merged

build: set MSRV to 1.75 and update fastrace #53

merged 2 commits into from
Aug 14, 2024

Conversation

andylokandy
Copy link
Contributor

@andylokandy andylokandy commented Aug 14, 2024 •
edited
Loading

No description provided.

@andylokandy andylokandy requested a review from tisonkun August 14, 2024 12:35
tisonkun
tisonkun approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you give some background why upgrade MSRV?

@tisonkun tisonkun changed the title chore: set MSRV to 1.75 and update fastrace build: set MSRV to 1.75 and update fastrace Aug 14, 2024
@andylokandy
Copy link
Contributor Author

andylokandy commented Aug 14, 2024 •
edited
Loading

It's because the dependency has a higher MSRV

@tisonkun tisonkun merged commit 28dc6f3 into fast:main Aug 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andylokandy @tisonkun