-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html show doc rendering #1460
Html show doc rendering #1460
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@jph00 - I am having trouble figuring out what to do about the failed test. It seems to just effect ubuntu python 3.9 and not other version/OS combos. It seems like the tests passed for the nbdev library, but Quarto is running into an error when trying to render the docs in the When I tried to research the error it looked like similar errors could be caused by incorrect quarto directives around multi-column layouts, however I don't think that's the case here since I can't find any multi-column directives that would cause this. |
Closing for debugging, will reopen when resolved |
Closing in order to create a clean PR with changes |
Improved
show_doc
rendering for HTML, including rending the documents table as an HTML table. This is useful in order to useshow_doc
with FastHTML apps.I cloned every fastai repo and checked for uses of the BasicHTMLRenderer that is being changed, and there were no uses (see result in image).