Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html show doc rendering #1460

Closed
wants to merge 24 commits into from

Conversation

Isaac-Flath
Copy link
Contributor

Improved show_doc rendering for HTML, including rending the documents table as an HTML table. This is useful in order to use show_doc with FastHTML apps.

I cloned every fastai repo and checked for uses of the BasicHTMLRenderer that is being changed, and there were no uses (see result in image).

Screenshot 2024-10-18 at 11 24 25 PM

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Isaac-Flath
Copy link
Contributor Author

@jph00 - I am having trouble figuring out what to do about the failed test. It seems to just effect ubuntu python 3.9 and not other version/OS combos. It seems like the tests passed for the nbdev library, but Quarto is running into an error when trying to render the docs in the test docs build on the tutorial.ipynb notebook.

When I tried to research the error it looked like similar errors could be caused by incorrect quarto directives around multi-column layouts, however I don't think that's the case here since I can't find any multi-column directives that would cause this.

nbdev/showdoc.py Outdated Show resolved Hide resolved
@Isaac-Flath
Copy link
Contributor Author

Closing for debugging, will reopen when resolved

@Isaac-Flath Isaac-Flath reopened this Oct 19, 2024
@Isaac-Flath
Copy link
Contributor Author

Closing in order to create a clean PR with changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants