Added rubocop and updated for all the violations

.rubocop.yml

@@ -0,0 +1 @@
+inherit_from: .rubocop_todo.yml

.rubocop_todo.yml

@@ -0,0 +1,253 @@
+Style/PercentLiteralDelimiters:
+  Enabled: false
+
+# kind_of? is a good way to check a type
+Style/ClassCheck:
+  EnforcedStyle: kind_of?
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# This doesn't work with older versions of Ruby (pre 2.4.0)
+Style/SafeNavigation:
+  Enabled: false
+
+# This doesn't work with older versions of Ruby (pre 2.4.0)
+Performance/RegexpMatch:
+  Enabled: false
+
+# This suggests use of `tr` instead of `gsub`. While this might be more performant,
+# these methods are not at all interchangable, and behave very differently. This can
+# lead to people making the substitution without considering the differences.
+Performance/StringReplacement:
+  Enabled: false
+
+# .length == 0 is also good, we don't always want .zero?
+Style/NumericPredicate:
+  Enabled: false
+
+# this would cause errors with long lanes
+Metrics/BlockLength:
+  Enabled: false
+
+# this is a bit buggy
+Metrics/ModuleLength:
+  Enabled: false
+
+# certificate_1 is an okay variable name
+Style/VariableNumber:
+  Enabled: false
+
+# This is used a lot across the fastlane code base for config files
+Style/MethodMissing:
+  Enabled: false
+
+#
+#   File.chmod(0777, f)
+#
+# is easier to read than
+#
+#   File.chmod(0o777, f)
+#
+Style/NumericLiteralPrefix:
+  Enabled: false
+
+#
+# command = (!clean_expired.nil? || !clean_pattern.nil?) ? CLEANUP : LIST
+#
+# is easier to read than
+#
+# command = !clean_expired.nil? || !clean_pattern.nil? ? CLEANUP : LIST
+#
+Style/TernaryParentheses:
+  Enabled: false
+
+# sometimes it is useful to have those empty methods
+Style/EmptyMethod:
+  Enabled: false
+
+# It's better to be more explicit about the type
+Style/BracesAroundHashParameters:
+  Enabled: false
+
+# specs sometimes have useless assignments, which is fine
+Lint/UselessAssignment:
+  Exclude:
+    - '**/spec/**/*'
+
+# We could potentially enable the 2 below:
+Style/IndentHash:
+  Enabled: false
+
+Style/AlignHash:
+  Enabled: false
+
+# HoundCI doesn't like this rule
+Style/DotPosition:
+  Enabled: false
+
+# We allow !! as it's an easy way to convert ot boolean
+Style/DoubleNegation:
+  Enabled: false
+
+# Prevent to replace [] into %i
+Style/SymbolArray:
+  Enabled: false
+
+# We still support Ruby 2.0.0
+Style/IndentHeredoc:
+  Enabled: false
+
+# This cop would not work fine with rspec
+Style/MixinGrouping:
+  Exclude:
+    - '**/spec/**/*'
+
+# Sometimes we allow a rescue block that doesn't contain code
+Lint/HandleExceptions:
+  Enabled: false
+
+# Cop supports --auto-correct.
+Lint/UnusedBlockArgument:
+  Enabled: false
+
+Lint/AmbiguousBlockAssociation:
+  Enabled: false
+
+# Needed for $verbose
+Style/GlobalVars:
+  Enabled: false
+
+# We want to allow class Fastlane::Class
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+# $? Exit
+Style/SpecialGlobalVars:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+# The %w might be confusing for new users
+Style/WordArray:
+  MinSize: 19
+
+# raise and fail are both okay
+Style/SignalException:
+  Enabled: false
+
+# Better too much 'return' than one missing
+Style/RedundantReturn:
+  Enabled: false
+
+# Having if in the same line might not always be good
+Style/IfUnlessModifier:
+  Enabled: false
+
+# and and or is okay
+Style/AndOr:
+  Enabled: false
+
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 320
+
+
+# Configuration parameters: AllowURI, URISchemes.
+Metrics/LineLength:
+  Max: 370
+
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 17
+
+Metrics/PerceivedComplexity:
+  Max: 18
+
+# Sometimes it's easier to read without guards
+Style/GuardClause:
+  Enabled: false
+
+# We allow both " and '
+Style/StringLiterals:
+  Enabled: false
+
+# something = if something_else
+# that's confusing
+Style/ConditionalAssignment:
+  Enabled: false
+
+# Better to have too much self than missing a self
+Style/RedundantSelf:
+  Enabled: false
+
+# e.g.
+# def self.is_supported?(platform)
+# we may never use `platform`
+Lint/UnusedMethodArgument:
+  Enabled: false
+
+# the let(:key) { ... }
+Lint/ParenthesesAsGroupedExpression:
+  Exclude:
+    - '**/spec/**/*'
+
+# This would reject is_ in front of methods
+# We use `is_supported?` everywhere already
+Style/PredicateName:
+  Enabled: false
+
+# We allow the $
+Style/PerlBackrefs:
+  Enabled: false
+
+# Disable '+ should be surrounded with a single space' for xcodebuild_spec.rb
+Style/SpaceAroundOperators:
+  Exclude:
+    - '**/spec/actions_specs/xcodebuild_spec.rb'
+
+AllCops:
+  Include:
+    - '**/fastlane/Fastfile'
+  Exclude:
+    - '**/lib/assets/custom_action_template.rb'
+    - './vendor/**/*'
+
+# They have not to be snake_case
+Style/FileName:
+  Exclude:
+    - '**/Dangerfile'
+    - '**/Brewfile'
+    - '**/Gemfile'
+    - '**/Podfile'
+    - '**/Rakefile'
+    - '**/Fastfile'
+    - '**/Deliverfile'
+    - '**/Snapfile'
+
+# We're not there yet
+Style/Documentation:
+  Enabled: false
+
+# Added after upgrade to 0.38.0
+Style/MutableConstant:
+  Enabled: false
+
+# length > 0 is good
+Style/ZeroLengthPredicate:
+  Enabled: false
+
+# Adds complexity
+Style/IfInsideElse:
+  Enabled: false
+
+# Sometimes we just want to 'collect'
+Style/CollectionMethods:
+  Enabled: false

Gemfile

@@ -49,6 +49,9 @@ group :development, :test do
 
   # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring
   gem 'spring'
+
+  # make sure our code is spick and span
+  gem 'rubocop', require: false
 end
 
 group :development do

Gemfile.lock

@@ -322,6 +322,7 @@ DEPENDENCIES
   rack (>= 1.6.11)
   rails (~> 5.0.0)
   rails_12factor
+  rubocop
   sass-rails (~> 5.0)
   spring
   uglifier (>= 1.3.0)

app/controllers/invite_controller.rb

@@ -4,7 +4,7 @@ class InviteController < ApplicationController
   before_action :check_disabled_text
   before_action :check_imprint_url
 
-  skip_before_filter :verify_authenticity_token
+  skip_before_action :verify_authenticity_token
 
   def index
     if boarding_service.user and boarding_service.password
@@ -30,7 +30,7 @@ def submit
       render :index
       return
     end
-    
+
     email = params[:email]
     first_name = params[:first_name]
     last_name = params[:last_name]
@@ -41,7 +41,7 @@ def submit
         if domains.count == 1
           @message = "Sorry! Early access is currently restricted to people within the #{domains.first} domain."
         else
-          @message = "Sorry! Early access is currently restricted to people within the following domains: (#{domains.join(", ")})"
+          @message = "Sorry! Early access is currently restricted to people within the following domains: (#{domains.join(', ')})"
         end
         @type = "warning"
         render :index
@@ -57,7 +57,7 @@ def submit
         return
       end
     end
-    
+
     if email.length == 0
       render :index
       return
@@ -89,47 +89,45 @@ def submit
   end
 
   private
-    def create_and_add_tester(email, first_name, last_name)
-      add_tester_response = boarding_service.add_tester(email, first_name, last_name)
-      @message = add_tester_response.message
-      @type = add_tester_response.type
-    end
 
-    def boarding_service
-      BOARDING_SERVICE
-    end
+  def create_and_add_tester(email, first_name, last_name)
+    add_tester_response = boarding_service.add_tester(email, first_name, last_name)
+    @message = add_tester_response.message
+    @type = add_tester_response.type
+  end
 
-    def app_metadata
-      Rails.cache.fetch('appMetadata', expires_in: 10.minutes) do
-        {
-          icon_url: boarding_service.app.app_icon_preview_url,
-          title: boarding_service.app.name
-        }
-      end
-    end
+  def boarding_service
+    BOARDING_SERVICE
+  end
 
-    def set_app_details
-      @metadata = app_metadata
-      @title = @metadata[:title]
+  def set_app_details
+    @metadata = app_metadata
+    @title = @metadata[:title]
 
-      tabIcon = ENV["TAB_ICON"].to_s
-      if tabIcon.to_s.length == 0
-        @tabIcon = "/BoardingIcon.ico"
-      else
-        @tabIcon = tabIcon
-      end
+    tabIcon = ENV["TAB_ICON"].to_s
+    if tabIcon.to_s.length == 0
+      @tabIcon = "/BoardingIcon.ico"
+    else
+      @tabIcon = tabIcon
     end
+  end
 
-    def check_disabled_text
-      if boarding_service.itc_closed_text
-        @message = boarding_service.itc_closed_text
-        @type = "warning"
-      end
+  def set_app_details
+    @metadata = app_metadata
+    @title = @metadata[:title]
+  end
+
+  def check_disabled_text
+    if boarding_service.itc_closed_text
+      @message = boarding_service.itc_closed_text
+      @type = "warning"
     end
+  end
 
-    def check_imprint_url
-      if boarding_service.imprint_url
-        @imprint_url = boarding_service.imprint_url
-      end
+  def check_imprint_url
+    if boarding_service.imprint_url
+      @imprint_url = boarding_service.imprint_url
     end
+  end
+
 end