Update dependencies, use ncc to bundle actions logic
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kailan
force-pushed
the
upload-artifact
branch
from
54ef47e
to
22a67e3
Compare
kailan
force-pushed
the
upload-artifact
branch
2 times, most recently
from
0ca61c6
to
34aa7df
Compare
…endencies into standalone files
kailan
force-pushed
the
upload-artifact
branch
from
34aa7df
to
b323fbc
Compare
kailan
requested review from
a team and
kpfleming
and removed request for
a team
kpfleming
approved these changes
Oct 21, 2024
| - Run `git tag -s "<TAG>" -m "<TAG>" && git push origin "<TAG>"`. | ||
| - Merge the pull request. |
There was a problem hiding this comment.
This appears to be out of order, as it's going to happen after the tag is made.
This should probably include a git checkout main && git pull after the PR is merged, to ensure that the local main branch is up to date before making the tag.
If you want to get even fancier, you can steal this which will for creating the tag even if the name of the remote is not origin (which is often the case for me).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the dependencies in order to resolve #58, but the diff was huge because of the need to include node_modules in the repository.
Following best practices that I found in other GitHub Actions, I've added a build step that uses
@vercel/nccto bundle dependencies and logic into single JS files for each action.