Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oneAPI 2025.0 include changes #1149

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

oneAPI 2025.0 include changes #1149

wants to merge 2 commits into from

Conversation

laurilaatu
Copy link
Contributor

Removing include for 2025.0

Type of change

oneAPI 2025.0 removes interfaces.hpp and the relevant functions are available from fpga_extensions.hpp

  • Bug fix (non-breaking change that fixes an issue)

Checklist

  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.

@jmitrevs
Copy link
Contributor

Changing this to draft till we update our test environment.

@jmitrevs jmitrevs marked this pull request as draft December 13, 2024 21:04
@jmitrevs jmitrevs self-assigned this Dec 13, 2024
@jmitrevs jmitrevs added this to the v1.1.0 milestone Jan 10, 2025
@jmitrevs jmitrevs added the please test Trigger testing by creating local PR branch label Jan 10, 2025
bo3z
bo3z requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@bo3z bo3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this but I would like to confirm this indeed works with oneAPI < 2025.0. If not, there should be an #ifdef checking for the version.

@JanFSchulte
Copy link
Contributor

Pytests have passed, so I guess this change is save an can be merged now?

@JanFSchulte JanFSchulte marked this pull request as ready for review January 10, 2025 19:07
@jmitrevs
Copy link
Contributor

The pytest wouldn't catch the failure since it's in the _test file. Lauri will add ifdefs, he said.

@JanFSchulte
Copy link
Contributor

Ah, I misunderstood. Great news about ifdefs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo3z bo3z bo3z requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@jmitrevs jmitrevs

Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@laurilaatu @jmitrevs @JanFSchulte @bo3z