-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Features about Number.prototype.toLocaleString()
for IE11 in win7 and 8, a lot of related new definitions (reopened again)
#57
base: main
Are you sure you want to change the base?
Conversation
Number.prototype.toLocaleString()
for IE11 in win7 and 8, a lot of related new definitions (reopened again)Number.prototype.toLocaleString()
for IE11 in win7 and 8, a lot of related new definitions (reopened again)
what should I do now? does your work finished? |
should I rearrange those IE11 related features? |
what happened to the project? |
I'm sorry, I still need some time to look into this, as I don't have fresh Windows 7 and Windows 8 VMs for testing. |
is getting that very hard in Europe? |
when will your work finished? |
src/lib/definitions.js
Outdated
useLocaleNumeralDefinition('ا', '"ar"', Infinity, 2, LOCALE_NUMERALS_IE11_WIN7_8); | ||
useLocaleNumeralDefinition('ن', '"ar"', Infinity, 4, LOCALE_NUMERALS_IE11_WIN7_8); | ||
useLocaleNumeralDefinition('ه', '"ar"', Infinity, 5, LOCALE_NUMERALS_IE11_WIN7_8); | ||
useLocaleNumeralDefinition('ﺓ', '"ar"', Infinity, 8, LOCALE_NUMERALS_IE11_WIN7_8); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting a different character. Did you mean this one?
useLocaleNumeralDefinition('ﺓ', '"ar"', Infinity, 8, LOCALE_NUMERALS_IE11_WIN7_8); | |
useLocaleNumeralDefinition('ة', '"ar"', Infinity, 8, LOCALE_NUMERALS_IE11_WIN7_8); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.
what should I do now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I still need to test this on Windows 7.
src/lib/definitions.js
Outdated
useLocaleNumeralDefinition('数', '"ja"', NaN, 6, LOCALE_NUMERALS_IE11_WIN7_8); | ||
useLocaleNumeralDefinition('値', '"ja"', NaN, 7, LOCALE_NUMERALS_IE11_WIN7_8); | ||
useLocaleNumeralDefinition('ė', '"lt"', Infinity, 7, LOCALE_NUMERALS_IE11_WIN7); | ||
useLocaleNumeralDefinition('ī', '"lv"', Infinity, 6, LOCALE_NUMERALS_IE11_WIN7_8); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting "∞"
for Infinity.toLocaleString("lv")
on Windows 8 with the latest updates.
what should I do now? |
Sorry for create a PR about that the third time. What should I do about IE11 subversions?