-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace aredis with redis-py #635
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #635 +/- ##
==========================================
- Coverage 94.13% 94.09% -0.05%
==========================================
Files 102 102
Lines 11093 11100 +7
Branches 1327 1328 +1
==========================================
+ Hits 10442 10444 +2
- Misses 554 557 +3
- Partials 97 99 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Faust doesn't work with ardis, because aredis support by python until 3.8. Miracle, python 3.9 is working with aredis, Faust with 3.11 doesn't work. We move with aredis to redis-py 🙏 |
I'm waiting to merge this until I've tested this against an actual Redis instance. |
We're going to have to get this merged if we want to support newer versions of Python. |
We need to get
aredis
out of Faust since it usesdistutils
, a library removed in Python 3.12.