Skip to content

Commit

Permalink
Fix Eclipse warnings in com.facebook.buck.maven package.
Browse files Browse the repository at this point in the history
Summary:
Normally, these would be caught by Ant, but `com.facebook.buck.maven`
is excluded from Ant compilation for the time being.

Test Plan: Yellow warning icons disappear in Eclipse.
  • Loading branch information
bolinfest authored and sdwilsh committed Mar 28, 2015
1 parent 4f02dcf commit 61a09da
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions src/com/facebook/buck/maven/Resolver.java
Original file line number Diff line number Diff line change
Expand Up @@ -392,10 +392,12 @@ public Prebuilt(String name, Path binaryJar) {
this.binaryJar = binaryJar;
}

@SuppressWarnings("unused") // This method is read reflectively.
public String getName() {
return name;
}

@SuppressWarnings("unused") // This method is read reflectively.
public Path getBinaryJar() {
return binaryJar;
}
Expand All @@ -404,6 +406,7 @@ public void setSourceJar(Path sourceJar) {
this.sourceJar = sourceJar;
}

@SuppressWarnings("unused") // This method is read reflectively.
public Path getSourceJar() {
return sourceJar;
}
Expand All @@ -412,6 +415,7 @@ public void addDep(String dep) {
this.deps.add(dep);
}

@SuppressWarnings("unused") // This method is read reflectively.
public SortedSet<String> getDeps() {
return deps;
}
Expand All @@ -420,6 +424,7 @@ public void addVisibility(String dep) {
this.visibilities.add(dep);
}

@SuppressWarnings("unused") // This method is read reflectively.
public SortedSet<String> getVisibility() {
return visibilities;
}
Expand Down
2 changes: 1 addition & 1 deletion test/com/facebook/buck/maven/ResolverIntegrationTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,6 @@ public void shouldOmitTargetsInTheSameBuildFileInVisibilityArguments() throws Ex

// Although the "deps-in-same-project" could be in the visibility param, it doesn't need to be
// because it's declared in the same build file.
assertEquals(0, ((Collection) noDeps.get("visibility")).size());
assertEquals(0, ((Collection<?>) noDeps.get("visibility")).size());
}
}

0 comments on commit 61a09da

Please sign in to comment.