Skip to content

Commit

Permalink
Add missing @AddToRuleKey annotations...
Browse files Browse the repository at this point in the history
Summary: and comment on why some others aren't needed.

Test Plan: CI

Reviewed By: ttsugriy

fbshipit-source-id: d6320d9
  • Loading branch information
cjhopman authored and facebook-github-bot committed Oct 3, 2017
1 parent ac7531a commit 813975a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,13 @@ abstract class AbstractJavacPluginProperties implements AddsToRuleKey {

public abstract ImmutableList<BuildRule> getClasspathDeps();

@AddToRuleKey
public abstract boolean getCanReuseClassLoader();

@AddToRuleKey
public abstract boolean getDoesNotAffectAbi();

@AddToRuleKey
public abstract boolean getSupportsAbiGenerationFromSource();

public boolean isEmpty() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,10 @@
public class ExternalOrJarBackedJavacProvider implements JavacProvider, AddsToRuleKey {
@AddToRuleKey private final SourcePath compiler;
@AddToRuleKey @Nullable private final String compilerClassName;
@AddToRuleKey private Javac.Location javacLocation;

// This is just used to cache the Javac derived from the other fields.
@Nullable private Javac javac;
private Javac.Location javacLocation;

public ExternalOrJarBackedJavacProvider(
SourcePath compiler, @Nullable String compilerClassName, Javac.Location javacLocation) {
Expand Down
2 changes: 2 additions & 0 deletions src/com/facebook/buck/jvm/java/JarBackedJavacProvider.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ public class JarBackedJavacProvider implements JavacProvider, AddsToRuleKey {
@AddToRuleKey private final SourcePath javacJarPath;
@AddToRuleKey private final String compilerClassName;
@AddToRuleKey private final Javac.Location javacLocation;

// This is just used to cache the Javac derived from the other fields.
@Nullable private Javac javac;

public JarBackedJavacProvider(
Expand Down

0 comments on commit 813975a

Please sign in to comment.