Removed avifEncOptions #14
Merged
+183
−202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
force-pushed
the
libavif-plugin
branch
3 times, most recently
from
57c87a8 to
0684398
Compare
radarhere
force-pushed
the
libavif-plugin
branch
2 times, most recently
from
38a2e27 to
a6ab8e9
Compare
fdintino
reviewed
Jan 3, 2025
Comment on lines
+403
to
+406
| avifImageDestroy(image); | ||
| avifEncoderDestroy(encoder); | ||
| Py_XDECREF(self->icc_bytes); | ||
| PyObject_Del(self); |
fdintino
reviewed
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions for python-pillow#5201
avifEncOptions. Its only purpose is to have the options set inAvifEncoderNew, and then to be read later inAvifEncoderNew, so it seems simpler to me to remove it. Feel free to disagree though.