Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor display type for instruction arguments #31

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Refactor display type for instruction arguments #31

merged 1 commit into from
Sep 26, 2023

Conversation

k0aki
Copy link
Contributor

@k0aki k0aki commented Sep 26, 2023

  • Replace DisplayArgValues type with simpler representation as atomic DisplayArgValues.
  • Add utility method for displaying list of arguments.

Y-Nak
Y-Nak approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@Y-Nak Y-Nak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Y-Nak Y-Nak merged commit e8679cd into fe-lang:main Sep 26, 2023
9 checks passed
@k0aki k0aki deleted the refactor-display-arg branch September 28, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Y-Nak Y-Nak Y-Nak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k0aki @Y-Nak