fix: multi patch raw false (#436)

* test: add tests for raw

* test: pass process.env.DB to connection.ts

* chore: logging for postgres & mysql

* fix: raw: false for multi patch

* test: custom NotFound with integer

* chore: gh actions global env

* chore: init mysql gh action

* chore: console.log connection

* chore: rm console.log

.github/workflows/nodejs.yml

@@ -2,6 +2,15 @@ name: CI
 
 on: [push, pull_request]
 
+env:
+  POSTGRES_USER: postgres
+  POSTGRES_PASSWORD: password
+  POSTGRES_DB: sequelize
+
+  MYSQL_USER: sequelize
+  MYSQL_DATABASE: sequelize
+  MYSQL_PASSWORD: password
+
 jobs:
   build:
 
@@ -11,18 +20,35 @@ jobs:
       postgres:
         image: postgres:12.12
         env:
-          POSTGRES_USER: postgres
-          POSTGRES_PASSWORD: password
-          POSTGRES_DB: sequelize
+          POSTGRES_USER: ${{ env.POSTGRES_USER }}
+          POSTGRES_PASSWORD: ${{ env.POSTGRES_PASSWORD }}
+          POSTGRES_DB: ${{ env.POSTGRES_DB }}
         ports:
           - 5432:5432
         # needed because the postgres container does not provide a healthcheck
         options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
 
+      mysql:
+        image: mysql:8.4
+        env:
+          # The MySQL docker container requires these environment variables to be set
+          # so we can create and migrate the test database.
+          # See: https://hub.docker.com/_/mysql
+          MYSQL_DATABASE: ${{ env.MYSQL_DATABASE }}
+          MYSQL_ROOT_PASSWORD: ${{ env.MYSQL_PASSWORD }}
+          MYSQL_USER: ${{ env.MYSQL_USER }}
+          MYSQL_PASSWORD: ${{ env.MYSQL_PASSWORD }}
+        ports:
+          # Opens port 3306 on service container and host
+          # https://docs.github.com/en/actions/using-containerized-services/about-service-containers
+          - 3306:3306
+          # Before continuing, verify the mysql container is reachable from the ubuntu host
+        options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries 5
+
     strategy:
       matrix:
         node-version: [18.x, 20.x, 22.x]
-        database: ['sqlite', 'postgres']
+        database: ['sqlite', 'postgres', 'mysql']
 
     steps:
       - uses: actions/checkout@v3

src/adapter.ts

@@ -358,6 +358,7 @@ export class SequelizeAdapter<
       let [, instances] = await Model
         .update(values, {
           ...sequelizeOptions,
+          raw: false,
           where: { [this.id]: ids.length === 1 ? ids[0] : { [Op.in]: ids } }
         } as UpdateOptions)
         .catch(errorHandler) as [number, Model[]?];

test/connection.ts

@@ -1,21 +1,36 @@
+import type { Options } from 'sequelize';
 import { Sequelize } from 'sequelize';
 
-export default (DB?: 'postgres' | 'mysql') => {
+export default (DB?: 'postgres' | 'mysql' | string) => {
+  const logging: Options['logging'] = false;
+
   if (DB === 'postgres') {
-    return new Sequelize('sequelize', 'postgres', 'password', {
-      host: 'localhost',
-      dialect: 'postgres'
-    });
+    return new Sequelize(
+      process.env.POSTGRES_DB ?? 'sequelize',
+      process.env.POSTGRES_USER ?? 'postgres',
+      process.env.POSTGRES_PASSWORD ?? 'password',
+      {
+        host: 'localhost',
+        dialect: 'postgres',
+        logging
+      }
+    );
   } else if (DB === 'mysql') {
-    return new Sequelize('sequelize', 'root', '', {
-      host: '127.0.0.1',
-      dialect: 'mysql'
-    });
+    return new Sequelize(
+      process.env.MYSQl_DATABASE ?? 'sequelize',
+      process.env.MYSQL_USER ?? 'root',
+      process.env.MYSQL_PASSWORD ?? '',
+      {
+        host: '127.0.0.1',
+        dialect: 'mysql',
+        logging
+      }
+    );
   } else {
     return new Sequelize('sequelize', '', '', {
       dialect: 'sqlite',
       storage: './db.sqlite',
-      logging: false
+      logging
     });
   }
 };

test/hooks.dehydrate.test.ts

@@ -4,7 +4,7 @@ import Sequelize from 'sequelize';
 
 import { dehydrate } from '../src/hooks/dehydrate';
 import makeConnection from './connection';
-const sequelize = makeConnection();
+const sequelize = makeConnection(process.env.DB);
 
 type MethodName = 'find' | 'get' | 'create' | 'update' | 'patch' | 'remove';
 

test/hooks.hydrate.test.ts

@@ -4,7 +4,7 @@ import Sequelize from 'sequelize';
 
 import { hydrate } from '../src/hooks/hydrate';
 import makeConnection from './connection'
-const sequelize = makeConnection();
+const sequelize = makeConnection(process.env.DB);
 
 type MethodName = 'find' | 'get' | 'create' | 'update' | 'patch' | 'remove';