Skip to content

Commit

Permalink
BaseEffectContext: ignore MAX_POSITION if the tween is actively playi…
Browse files Browse the repository at this point in the history
…ng (closes #1827)
  • Loading branch information
joshtynjala committed Jul 31, 2024
1 parent 3d4ec27 commit 68717a9
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion source/feathers/motion/effectClasses/BaseEffectContext.as
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,10 @@ package feathers.motion.effectClasses
*/
public function set position(value:Number):void
{
if(value > MAX_POSITION)
// there are some quirks with Starling tweens where we want to avoid
// going all of the way to the end, unless the tween is currently
// playing
if(!this._playing && value > MAX_POSITION)
{
value = MAX_POSITION;
}
Expand Down

0 comments on commit 68717a9

Please sign in to comment.