Externalize the 'difference/s' text eclipse-platform#1236

Externalization of text used in "Textmergeviewer.java" related to number of differences shown in toolbar of compare editor using MessageFormat.format Version bump to 3.10.100 Update team/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/CompareMessages.properties Co-authored-by: Matthias Becker <ma.becker@sap.com>
fedejeanne · Mar 25, 2024 · 072423e · 072423e
1 parent a75a0bf
commit 072423e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/...s/org.eclipse.compare/compare/org/eclipse/compare/contentmergeviewer/TextMergeViewer.java b/...s/org.eclipse.compare/compare/org/eclipse/compare/contentmergeviewer/TextMergeViewer.java
@@ -5413,8 +5413,7 @@ private void updateToolbarLabel() {
 		int differenceCount = fMerger.changesCount();
 		if (tbm != null) {
 
-			String label = differenceCount > 1 ? differenceCount + " Differences" //$NON-NLS-1$
-					: differenceCount == 1 ? differenceCount + " Difference" : "No Difference"; //$NON-NLS-1$ //$NON-NLS-2$
+			String label = MessageFormat.format(CompareMessages.TextMergeViewer_differences, differenceCount);
 			LabelContributionItem labelContributionItem = new LabelContributionItem(DIFF_COUNT_ID,
 					label);
 

diff --git a/team/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/CompareMessages.java b/team/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/CompareMessages.java
@@ -96,6 +96,7 @@ private CompareMessages() {
 	public static String TextMergeViewer_atEnd_message;
 	public static String TextMergeViewer_atBeginning_title;
 	public static String TextMergeViewer_atBeginning_message;
+	public static String TextMergeViewer_differences;
 	public static String CompareNavigator_atEnd_title;
 	public static String CompareNavigator_atEnd_message;
 	public static String CompareNavigator_atBeginning_title;

diff --git a/...ndles/org.eclipse.compare/compare/org/eclipse/compare/internal/CompareMessages.properties b/...ndles/org.eclipse.compare/compare/org/eclipse/compare/internal/CompareMessages.properties
@@ -81,6 +81,8 @@ TextMergeViewer_accessible_right={0} Right: {1}
 TextMergeViewer_atBeginning_message= Beginning of document reached. Continue from end?
 TextMergeViewer_accessible_ancestor=Ancestor: {0}
 
+TextMergeViewer_differences={0,choice,0#No Difference|1#1 Difference|1<{0} Differences}
+
 CompareNavigator_atEnd_title= End Reached
 CompareDialog_commit_button=C&ommit
 CompareDialog_error_title=Error Saving Changes