Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring business logic communication #45

Merged
merged 7 commits into from
Mar 21, 2024

Conversation

Berlimor
Copy link
Contributor

No description provided.

@Berlimor Berlimor requested review from PaTara43 and timofeev41 March 20, 2024 09:33
@Berlimor Berlimor self-assigned this Mar 20, 2024
Copy link
Contributor

@timofeev41 timofeev41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ярко

Comment on lines -73 to +76
dir_ = pathlib.Path("unit-passports")

def _save_certificate(unit: Unit, certificate_dict: dict[str, Any], path: str) -> None:
"""makes a unit certificate and dumps it in a form of a YAML file"""
dir_ = pathlib.Path("unit-certificates")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaTara43 точно все ок будет если мы пусть поменяем с unit-passports на unit-certificates?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Berlimor да, точно, обосрется. в docker-compose поменяй в волюмах строчку с - "./unit-passports/:/src/unit-passports/"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Berlimor Поменяешь?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поменяю, да

@timofeev41
Copy link
Contributor

я аппрувнул в надежде что ты сам потестил и сервис хотя бы запускается)

Copy link
Contributor

@PaTara43 PaTara43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поулчается, в stage_data будет cid со всеми данными?
Как это будет выглядеть?

@Berlimor
Copy link
Contributor Author

@PaTara43 В stage_data будет вообще всё, что может быть. С диспетчера туда идёт cid и ipfs_link, а в случае с оператором там, помимо ipfs приколов, лежат factory_card_id и поле detail, в котором просто текстом сообщается, что всё ок.

@PaTara43 PaTara43 merged commit 620fecf into refactoring Mar 21, 2024
1 check failed
@PaTara43 PaTara43 deleted the refactoring-business-logic-communication branch March 27, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants