Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.md #2

Merged
merged 1 commit into from
May 30, 2018
Merged

Update index.md #2

merged 1 commit into from
May 30, 2018

Conversation

feiandytan
Copy link
Owner

@feiandytan feiandytan commented May 30, 2018 •
edited
Loading

closes #2

@github-learning-lab
Copy link

@feiandytan It looks like you left your Pull Request empty. This is completely fine, but did you know that you can set issues to automatically close when a Pull Request is merged?

For example, if you had written closes #2 in the opening body of your Pull Request, that open issue would close when you finish this exercise!

Also, this works for more than just the closes keyword.

If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.

Check below for next steps

github-learning-lab[bot]
github-learning-lab bot approved these changes May 30, 2018
View reviewed changes
Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 3: Merge your pull request

Your pull request looks awesome! Go ahead and merge 📖 it now @feiandytan.

⌨️ Activity: Merge your pull request

  1. Click Merge pull request below
  2. Click Confirm merge
  3. Go ahead and delete your branch in this pull request

Watch below for my response

@feiandytan feiandytan merged commit 62f767e into master May 30, 2018
@github-learning-lab
Copy link

Good work @feiandytan! This pull request is all finished up.

Go to your next task now!

@github-learning-lab
Copy link

Good work @feiandytan! This pull request is all finished up.

Go to your next task now!

@feiandytan feiandytan deleted the feiandytan-patch-1 branch May 30, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-learning-lab GitHub Learning Lab github-learning-lab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@feiandytan