Skip to content
This repository has been archived by the owner on Aug 20, 2022. It is now read-only.

feat: placement by option #210

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: placement by option #210

wants to merge 3 commits into from

Conversation

frederikgodejohann
Copy link

@r12r
Copy link

r12r commented Sep 17, 2019

It works very well!
Maybe helpful for other people:
Possible values:
top-left
top-right
bottom-left
bottom-right

@frederikgodejohann
Copy link
Author

@fengyuanchen
Hi, would you please review this PR?
I would highly appreciate that.

The changes i made, were because of a glitch in placement-detection inside a grid-container.
It was an rare edge case. For my usage case the placement could easily be hardcoded - thus avoiding auto detection. So i implemented that. I even think auto-positioning isn't always the best choice, when you don't want to obstruct the simultaneos visibility of other elements on the page.

@fengyuanchen
Copy link
Owner

@frederikgodejohann I might not have time to maintain this project. I'm sorry.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frederikgodejohann @r12r @fengyuanchen