Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #562 enhance zoom origin behavior when using icons in the control bar to zoom image #615

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SusieWen777
Copy link

This allows the zoom origin to behave as the follows when using icons in the control bar to zoom image:

  • If the image has been clicked by the mouse or been touched, the zoom origin will be the last place of the mouse or the touch point.
  • Otherwise, the zoom origin will be the center of the image.

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of the default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

This commit addresses the issue of zoom origin when using zoom and zoomTo functions.

Closes fengyuanchen#562
This commit refines the comments for clarity regarding the zoom origin behavior when using zoom and zoomTo functions. Additionally, the project has been rebuilt.

Closes fengyuanchen#562
@SusieWen777 SusieWen777 marked this pull request as ready for review October 27, 2023 05:58
@fengyuanchen
Copy link
Owner

Don't add auto-generated files (dist/* and docs/js/viewer.js).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants