fix: add support when using @vue/compat aka migration build #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users migrating vue2 apps to vue3 usually start with this package if their app is non trivial. The migration build is usually set with MODE: 2 for compiling, but since this component is written in vue3 format we need to let vue compiler know.
Alternative: Manually patching
import VueCountdown from '@chenfengyuan/vue-countdown'
VueCountdown.compatConfig = { MODE: 3 }
|
@fengyuanchen Hi, are there any plans to merge this? Let me know if you need help maintaining this package, I will be glad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users migrating vue2 apps to vue3 usually start with this package1 if their app is non-trivial. The migration build is usually set with
MODE: 2for having maximum backwards compatibility, but since this component is written in vue3 format we need to let the Vue compiler know.Alternative: Manually patching
Users can work around this by manually patching the exported object, but less experienced users might not be aware of it when they just see a runtime error in the console.
Footnotes
https://v3-migration.vuejs.org/migration-build.html ↩