Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 addon, embroider compat, use pnpm, drop ember <= 4.8 #334

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

AmauryD
Copy link

@AmauryD AmauryD commented Feb 5, 2024

TODO:

  • Remove the references to @TRIPTYK before merging
  • Get fastboot support back (add tests ?)

@AmauryD AmauryD mentioned this pull request Feb 5, 2024
@AmauryD AmauryD marked this pull request as ready for review February 7, 2024 15:44
@spruce
Copy link

spruce commented Mar 8, 2024

I think the initializers are no longer neccessary.
I just added the authenticator into the authenticators folder of my app and without any initializers it got found.

@fenichelar fenichelar assigned fenichelar and unassigned fenichelar Mar 27, 2024
@fenichelar
Copy link
Owner

@ChrisN-transnexus

@gzurbach
Copy link

gzurbach commented Apr 9, 2024

This looks great! We would love to see this merged so that we can update our app to Ember 5. Thanks for working on this @AmauryD 👍

@ChrisN-transnexus
Copy link

@AmauryD I tried to install this in an Ember 5.4.1 app via pnpm i https://github.com/AmauryD/ember-simple-auth-token.git but ran into difficulties.

The consuming app uses @embroider/webpack and @embroider/compat, ember-auto-import 2.6.3, webpack 5.78.0 and @embroider/addon-dev 4.3.1, but the resulting code installed under node_modules/workspace-root and is referenced in package.json as "workspace-root": "github:AmauryD/ember-simple-auth-token"

The consuming app can't import the ember-simple-auth-token modules when they are under workspace-root. Am I doing something wrong or does the consuming app need some config changes?

@AmauryD
Copy link
Author

AmauryD commented Apr 19, 2024

@AmauryD I tried to install this in an Ember 5.4.1 app via pnpm i https://github.com/AmauryD/ember-simple-auth-token.git but ran into difficulties.

The consuming app uses @embroider/webpack and @embroider/compat, ember-auto-import 2.6.3, webpack 5.78.0 and @embroider/addon-dev 4.3.1, but the resulting code installed under node_modules/workspace-root and is referenced in package.json as "workspace-root": "github:AmauryD/ember-simple-auth-token"

The consuming app can't import the ember-simple-auth-token modules when they are under workspace-root. Am I doing something wrong or does the consuming app need some config changes?

Hello @ChrisN-transnexus,

Installing an Ember V2 addon directly using github isn't possible due to the dist build not being published by default. I've added a CI task to solve this problem. You can install the dist build on this branch: link.

pnpm add -D https://github.com/AmauryD/ember-simple-auth-token.git\#master-dist --ignore-scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants