Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating README and improving http status error #20

Merged
merged 2 commits into from
Jul 17, 2024
Merged

updating README and improving http status error #20

merged 2 commits into from
Jul 17, 2024

Conversation

asteurer
Copy link
Contributor

No description provided.

Signed-off-by: Andrew Steurer <andrew.steurer@fermyon.com>
@asteurer asteurer assigned macolso and unassigned macolso Jul 16, 2024
@asteurer asteurer requested a review from macolso July 16, 2024 15:16
Copy link
Collaborator

@macolso macolso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small language tweak and a suggestion to add a CTA to engage with Discord if there are any open questions. Then I think we should be good to go.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Signed-off-by: Andrew Steurer <andrew.steurer@fermyon.com>
@asteurer asteurer requested a review from macolso July 17, 2024 00:52
Copy link
Collaborator

@macolso macolso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making those tweaks.

@asteurer asteurer merged commit da5fdc8 into fermyon:main Jul 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants