Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add the os menu #957

Merged
merged 21 commits into from
Sep 30, 2024
Merged

feat(docs): add the os menu #957

merged 21 commits into from
Sep 30, 2024

Conversation

gautamgambhir97
Copy link
Collaborator

@gautamgambhir97 gautamgambhir97 commented Sep 24, 2024

Proposed Changes

Add a OS toggle for commands in docs

Linked Issues

[if applicable, add links to issues resolved by this PR]

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Content update.
  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

Further comments

[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]

@gautamgambhir97 gautamgambhir97 changed the title Feat/add the os menu feat(docs): add the os menu Sep 24, 2024
@gautamgambhir97 gautamgambhir97 added the s-hold Status: On Hold - Not to be merged until given approval from repo owner. label Sep 24, 2024
@devjsc
Copy link
Member

devjsc commented Sep 24, 2024

Added the OS tab to individual code blocks as we discussed and designed. I think api-endpoint could be renamed now to code-blocks or similar to reflect better what it is. Will need to review designs again as I am concerned we could clutter the flow in guides with multiple selectors etc.

@devjsc devjsc removed the s-hold Status: On Hold - Not to be merged until given approval from repo owner. label Sep 30, 2024
@devjsc devjsc merged commit 632f549 into main Sep 30, 2024
4 checks passed
@devjsc devjsc deleted the feat/add-the-os-menu branch September 30, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants