addressing revive hints

fever-ch · Aug 21, 2023 · 9ef0f6d · 9ef0f6d
1 parent 0c8492d
commit 9ef0f6d
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 11 deletions.
diff --git a/app/common.go b/app/common.go
@@ -14,6 +14,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
+// Package app provides the main logic for the app
 package app
 
 import (

diff --git a/app/pinger_test.go b/app/pinger_test.go
@@ -57,7 +57,7 @@ func (webClientBuilderMock *webClientBuilderMock) URL() string {
 	return "https://www.google.com"
 }
 
-func (webClientBuilderMock *webClientBuilderMock) SetURL(url *url.URL) {
+func (webClientBuilderMock *webClientBuilderMock) SetURL(*url.URL) {
 	// not needed
 }
 

diff --git a/app/resolver.go b/app/resolver.go
@@ -91,7 +91,7 @@ func resolveWithSpecificServer(network, server string, host string) ([]*net.IP,
 	} else if network == "ip6" {
 		return resolveWithSpecificServerQtype(dns.TypeAAAA, server, host)
 	} else {
-		var ipv4Address []*net.IP = nil
+		var ipv4Address []*net.IP
 
 		answersChan := make(chan *resolveAnswer)
 

diff --git a/app/webclientimpl.go b/app/webclientimpl.go
@@ -115,7 +115,7 @@ func newHTTP2RoundTripper(config *Config, runtimeConfig *RuntimeConfig, w *webCl
 		return sockettrace.NewSocketTrace(ctx, dialer, network, ipaddr)
 	}
 
-	var tlsNextProto map[string]func(string, *tls.Conn) http.RoundTripper = nil
+	var tlsNextProto map[string]func(string, *tls.Conn) http.RoundTripper
 
 	if webClient.config.HTTP1 {
 		tlsNextProto = make(map[string]func(string, *tls.Conn) http.RoundTripper)
@@ -345,21 +345,19 @@ func extractTLSVersion(res *http.Response) string {
 		code := int(res.TLS.Version) - 0x0301
 		if code >= 0 {
 			return fmt.Sprintf("TLS-1.%d", code)
-		} else {
-			return "SSL-3"
 		}
-	} else {
-		return "N/A"
+		return "SSL-3"
+
 	}
+	return "N/A"
+
 }
 
 func (webClient *webClientImpl) moveToHTTP3(altSvcH3 string, timerRegistry *stats.TimerRegistry, followRedirect bool) *HTTPMeasure {
 
-	if altSvcH3 == ":443" {
-		// nothing
-	} else if strings.HasPrefix(altSvcH3, ":") {
+	if strings.HasPrefix(altSvcH3, ":") {
 		webClient.url.Host = webClient.url.Host + altSvcH3
-	} else {
+	} else if altSvcH3 != ":443" {
 		webClient.url.Host = altSvcH3
 	}
 

diff --git a/cmd/root.go b/cmd/root.go
@@ -14,6 +14,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
+// Package cmd provides parsing of command-line parameters
 package cmd
 
 import (

diff --git a/net/sockettrace/adapter.go b/net/sockettrace/adapter.go
@@ -14,6 +14,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
+// Package sockettrace provides tracing mechanisms
 package sockettrace
 
 import (

diff --git a/stats/base.go b/stats/base.go
@@ -14,6 +14,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
+// Package stats provides simple and basic functions for statistics
 package stats
 
 import "math"