reducing code smell

fever-ch · Aug 18, 2023 · d257d0f · d257d0f
1 parent 6b52302
commit d257d0f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/cmd/root_test.go b/cmd/root_test.go
@@ -63,30 +63,30 @@ func commandTest(_ *testing.T, args []string) (*app.Config, []byte, error) {
 }
 
 func TestCount(t *testing.T) {
-	config, _, err := commandTest(t, []string{"-c", "123", "www.google.com"})
+	config, _, err := commandTest(t, []string{"-c", "123", "www.google.ch"})
 	if err != nil || config.Count != 123 {
 		t.Fatal("Count parameter not taken in account")
 	}
 }
 
 func TestEnforceIPv6(t *testing.T) {
-	config, _, err := commandTest(t, []string{"-6", "www.google.com"})
+	config, _, err := commandTest(t, []string{"-6", "ipv6.google.com"})
 	if err != nil && config.IPProtocol != "ip6" {
 		t.Fatal("IPv6 parameter not taken in account")
 	}
 
 }
 
 func TestEnforceIPv4AndIPv6(t *testing.T) {
-	_, _, err := commandTest(t, []string{"-4", "-6", "www.google.com"})
+	_, _, err := commandTest(t, []string{"-4", "-6", "www.epfl.ch"})
 	if err == nil {
 		t.Fatal("IPv6 parameter not taken in account")
 	}
 
 }
 
 func TestExcessOfArguments(t *testing.T) {
-	_, _, err := commandTest(t, []string{"www.google.com", "www.wikipedia.com"})
+	_, _, err := commandTest(t, []string{"www.ietf.org", "www.wikipedia.org"})
 	if err == nil {
 		t.Fatal("only one non-flag argument can we used")
 	}

diff --git a/net/sockettrace/adapter_test.go b/net/sockettrace/adapter_test.go
@@ -48,8 +48,10 @@ func TestInterceptionOfHTTPRequest(t *testing.T) {
 	ctxA := WithTrace(context.Background(),
 		&ConnTrace{
 			Read: func(i int) {
+				// ignored here
 			},
 			Write: func(i int) {
+				// ignored here
 			},
 			TCPStart: func() {
 				tcpStartedA = true
@@ -62,8 +64,10 @@ func TestInterceptionOfHTTPRequest(t *testing.T) {
 	ctxB := WithTrace(ctxA,
 		&ConnTrace{
 			Read: func(i int) {
+				// ignored here
 			},
 			Write: func(i int) {
+				// ignored here
 			},
 			TCPStart: func() {
 				tcpStartedB = true