Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert changes which can be packaged #1

Open
wants to merge 3 commits into
base: v2023.2.x-parker
Choose a base branch
from

Conversation

maurerle
Copy link

@maurerle maurerle commented Nov 2, 2024

This reverts the two vpn provider related patches, which are not required when using gluon-mesh-vpn-parker or ffbs-mesh-vpn-parker from SmithChart/community-packages@topic/parker...ffac:community-packages:parker

@SmithChart
Copy link

please rebase

@maurerle
Copy link
Author

I would rather force-push the v2023.2.x-parker branch to drop those two patches.

This PR was meant to test this concept and it seems that it works fine with the latest ffbs-mesh-vpn-parker package

@maurerle maurerle changed the title V2023.2.x parker revert changes which can be packaged Nov 27, 2024
@maurerle
Copy link
Author

I added staging removals.
When building parker with the changes from these two pull-requests, everything should be working fine:
SmithChart/community-packages#2
SmithChart/community-packages#3

This should be the next thing to test

@SmithChart
Copy link

I would rather force-push the v2023.2.x-parker branch to drop those two patches.

This PR was meant to test this concept and it seems that it works fine with the latest ffbs-mesh-vpn-parker package

I would prefer a force-push instead of reverting, too. If you are interested I can give you access to this repo.

@SmithChart
Copy link

I added staging removals. When building parker with the changes from these two pull-requests, everything should be working fine: SmithChart/community-packages#2 SmithChart/community-packages#3

This should be the next thing to test

SmithChart/community-packages#3 has been merged. Commits have been dropped.
SmithChart/community-packages#2 has discussion going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants