fix(*) catch and fix more GC corner cases #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fffonion
force-pushed
the
valgrind-gc
branch
5 times, most recently
from
4c7cc18 to
8abdb67
Compare
fffonion
changed the title
| ffi_gc(got_ref, stack_lib.gc_of("GENERAL_NAME")) | ||
| got = ffi_cast("GENERAL_NAMES*", got_ref)''', | ||
| got = ffi_cast("GENERAL_NAMES*", got_ref) | ||
| ffi_gc(got, stack_lib.gc_of("GENERAL_NAME"))''', |
There was a problem hiding this comment.
If you have set ffi.gc function for got_ref in the upper layer function, then the underlying object would be freeed two times by the ffi.gc.
There was a problem hiding this comment.
It won't be double free because got_ref is a opaque pointer, it doesn't have GC handler to free the pointed object. we only have gc handler for got.
store:check_revocation
…name, info_access and dist_points
|
@zhuizhuhaomeng The tests are now green with the new valgrind setup, I'm going to merge this and looking to make the tests faster. Any suggestions are welcomed! And thanks for bringing this up, it's also a learning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.