Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes and fixes #50

Merged
merged 6 commits into from
Sep 2, 2024
Merged

Conversation

mcaskill
Copy link
Contributor

@mcaskill mcaskill commented Aug 6, 2024

Various changes and fixes to allow tests to pass and support more recent versions of PHP.

  • Fix support for Composer 2.2.0 and newer:
    • Allow dealerdirect/phpcodesniffer-composer-installer in root manifest.
    • Allow composer/installers and ffraenz/private-composer-installer in test manifests.
  • Fix issues reported by PHPCS:
    • Add strict_types declaration to test files.
  • Remove obsolete version from Docker Compose file.
  • Fix GitHub Actions workflow:
    • Ensure platform requirement is checked to ensure the appropriate dependencies are installed which fixes installation of Composer dependencies for PHP 8.0.
    • Include testing of PHP 8.1, 8.2, 8.3, and 8.4 (allow to fail).

Add `strict_types` declaration to test files.
Add missing `config.allow-plugins` to `composer.json` files for Composer 2.2.0 and newer.

See https://getcomposer.org/allow-plugins
Ensure platform requirement (PHP) is checked to ensure the appropriate dependencies are installed.

For example, ignoring that the platform is PHP 8.0 would install a version of symfony/console that expectes PHP 8.1.
Include testing for PHP 8.1, 8.2, 8.3, and 8.4 (allow to fail).
@mcaskill mcaskill force-pushed the feature/maintenance branch from c8d2e29 to c8071dd Compare August 6, 2024 16:50
@ffraenz ffraenz changed the base branch from main to dev September 2, 2024 15:47
@ffraenz ffraenz merged commit 95f80b4 into ffraenz:dev Sep 2, 2024
27 checks passed
@ffraenz
Copy link
Owner

ffraenz commented Sep 2, 2024

Great work, thank you @mcaskill!

@mcaskill mcaskill deleted the feature/maintenance branch September 2, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants