Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-opcode packets #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pmgr
Copy link

@pmgr pmgr commented Dec 14, 2022

Change was prompted by making the resultDialog packet behave closer to what the client does; in reality it's a SuperPacket that's part of FFXIV's Event system, and it has one opcode per possible fixed length. ResultDialog was thus renamed to EventResume, which is more appropriate to its actual function.

To support this, the Opcodes definition for ServerZoneIpcType had to be changed to a union of number and Array.

EventResume.category thus represents an EventHandlerType, which informs how the packet is handled by its specific EventHandler; some branch off into sub-packets (MarketTaxRates) while others stand on their own (such as DesynthResult).

These sub-packets were also changed to add more fields sent by the server, with an entirely new added packet for materia retrieval (RetrieveMateriaResult).

Finally, changed the end of line setting in prettier to match what the actual committed files in the repo used.

Huge commit is huge. 🙃

@Supamiu
Copy link
Member

Supamiu commented Dec 14, 2022

lgtm, will do a bit of testing before approving and merging before release, thanks post-autumn boi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants