Skip to content

Commit

Permalink
Merge pull request #36 from jshufro/jms/fix-deletion-false-negative
Browse files Browse the repository at this point in the history
Use all_modified_files.json instead of all_changed_files.json
  • Loading branch information
fgrosse authored Jul 25, 2024
2 parents ff33f0f + b5e8ae2 commit 01ee5ff
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
_Nothing yet_
- Fix issue with code coverage information missing when test files are deleted (fgrosse/go-coverage-report#35)

## [v1.0.2] - 2024-06-11
- Fix issue when coverage artifact contains more files than just the `coverage.txt` file (fgrosse/go-coverage-report#25)
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ runs:
GH_TOKEN: ${{ github.token }}
GITHUB_WORKFLOW: ${{ github.workflow }}
GITHUB_BASE_REF: ${{ github.base_ref }}
CHANGED_FILES_PATH: .github/outputs/all_changed_files.json
CHANGED_FILES_PATH: .github/outputs/all_modified_files.json
COVERAGE_ARTIFACT_NAME: ${{ inputs.coverage-artifact-name }}
COVERAGE_FILE_NAME: ${{ inputs.coverage-file-name }}
ROOT_PACKAGE: ${{ inputs.root-package }}
Expand Down
4 changes: 2 additions & 2 deletions scripts/github-action.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ You can use the following environment variables to configure the script:
- GITHUB_BASE_REF: The base branch to compare the coverage results against (default: main)
- COVERAGE_ARTIFACT_NAME: The name of the artifact containing the code coverage results (default: code-coverage)
- COVERAGE_FILE_NAME: The name of the file containing the code coverage results (default: coverage.txt)
- CHANGED_FILES_PATH: The path to the file containing the list of changed files (default: .github/outputs/all_changed_files.json)
- CHANGED_FILES_PATH: The path to the file containing the list of changed files (default: .github/outputs/all_modified_files.json)
- ROOT_PACKAGE: The import path of the tested repository to add as a prefix to all paths of the changed files (optional)
- TRIM_PACKAGE: Trim a prefix in the \"Impacted Packages\" column of the markdown report (optional)
"
Expand All @@ -51,7 +51,7 @@ COVERAGE_FILE_NAME=${COVERAGE_FILE_NAME:-coverage.txt}
OLD_COVERAGE_PATH=.github/outputs/old-coverage.txt
NEW_COVERAGE_PATH=.github/outputs/new-coverage.txt
COVERAGE_COMMENT_PATH=.github/outputs/coverage-comment.md
CHANGED_FILES_PATH=${CHANGED_FILES_PATH:-.github/outputs/all_changed_files.json}
CHANGED_FILES_PATH=${CHANGED_FILES_PATH:-.github/outputs/all_modified_files.json}

if [[ -z ${GITHUB_REPOSITORY+x} ]]; then
echo "Missing github_repository argument"
Expand Down

0 comments on commit 01ee5ff

Please sign in to comment.