Skip to content

Commit

Permalink
Update configuration and add missing env variable
Browse files Browse the repository at this point in the history
  • Loading branch information
fibelatti committed Oct 22, 2024
1 parent 7f66d34 commit ca9f096
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/signed-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
- name: Build
run: ./gradlew app:assemblePinboardapiRelease
env:
SIGN_BUILD: true
SIGNING_KEY_ALIAS: ${{ secrets.SIGNING_KEY_ALIAS }}
SIGNING_KEY_PASSWORD: ${{ secrets.SIGNING_KEY_PASSWORD }}
SIGNING_STORE_PASSWORD: ${{ secrets.SIGNING_STORE_PASSWORD }}
Expand Down Expand Up @@ -54,7 +55,7 @@ jobs:
- name: Build
run: ./gradlew app:bundlePinboardapiRelease
env:
SIGN_BUILD: "true"
SIGN_BUILD: true
SIGNING_KEY_ALIAS: ${{ secrets.SIGNING_KEY_ALIAS }}
SIGNING_KEY_PASSWORD: ${{ secrets.SIGNING_KEY_PASSWORD }}
SIGNING_STORE_PASSWORD: ${{ secrets.SIGNING_STORE_PASSWORD }}
Expand Down
2 changes: 1 addition & 1 deletion app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ android {
isShrinkResources = true
isCrunchPngs = false

if (System.getenv("SIGN_BUILD") == "true") {
if (System.getenv("SIGN_BUILD").toBoolean()) {
signingConfig = signingConfigs.getByName("release")
}

Expand Down

0 comments on commit ca9f096

Please sign in to comment.