Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid response on cancel fixes #381 #382

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

denisacostaq
Copy link

Fixes #381

Changes:

  • fix change pin tests and remove pin implementation
  • bootloader - fix firmware upload, button request on confirmation trough wire
  • Fix changePin message

Does this change need to mentioned in CHANGELOG.md?
no

Requires testing
yes

@stdevAlDen stdevAlDen requested a review from olemis February 28, 2020 04:27
@stdevAlDen stdevAlDen self-assigned this Feb 28, 2020
@stdevAlDen stdevAlDen added bootloader MCU bootloader bug Something isn't working firmware MCU firmware labels Feb 28, 2020
@olemis olemis added this to the v2 milestone Mar 4, 2020
Copy link
Collaborator

@olemis olemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firmware test suite needs to cover the case of PIN op cancellation

Alvaro Denis added 2 commits March 4, 2020 18:43
@olemis olemis changed the title invald response on cancel invalid response on cancel fixes #381 Mar 5, 2020
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t381_invald_response_on_cancel branch 3 times, most recently from c762bad to 27e99a4 Compare March 5, 2020 21:11
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t381_invald_response_on_cancel branch from 27e99a4 to 5f32cc5 Compare March 5, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootloader MCU bootloader bug Something isn't working firmware MCU firmware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid response on cancel
3 participants